Dear Jagan Teki,
On 21/12/13 04:00, Jagan Teki wrote:
Hi Inderpal Singh,
On Thu, Aug 8, 2013 at 7:15 PM, Jagan Teki jagannadh.teki@gmail.com wrote:
Hi,
On Thu, Jun 20, 2013 at 1:40 PM, Inderpal Singh inderpal.singh@linaro.org wrote:
Hi Jagan,
On 13 June 2013 01:08, Jagan Teki jagannadh.teki@gmail.com wrote:
Hi,
Can you separate the PMIC and SPI changes into two different patches.
Since its a minor clean up patch. I feel there is no need to split it into two.
Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?
As I mentioned in the commit message , these configs are redundant. They have already been defined in the same file.
Thanks, Inder
-- Thanks, Jagan.
On 07-06-2013 17:25, Inderpal Singh wrote:
They have been defined once already. Hence remove the redundant definitions.
Signed-off-by: Inderpal Singh inderpal.singh@linaro.org
v1 was posted as the first patch of [1]
Changes in v2: - split from the patchset at [1] - removed redundant configs for PMIC - rebased to latest u-boot-samsung master branch
[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101
include/configs/exynos5250-dt.h | 26 -------------------------- 1 file changed, 26 deletions(-)
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h index 62b83d4..03b07b2 100644 --- a/include/configs/exynos5250-dt.h +++ b/include/configs/exynos5250-dt.h @@ -246,11 +246,6 @@ #define CONFIG_SYS_I2C_SLAVE 0x0 #define CONFIG_I2C_EDID
-/* PMIC */ -#define CONFIG_PMIC -#define CONFIG_PMIC_I2C -#define CONFIG_PMIC_MAX77686
- /* SPI */ #define CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SPI_FLASH
@@ -278,27 +273,6 @@ #define CONFIG_POWER_I2C #define CONFIG_POWER_MAX77686
-/* SPI */ -#define CONFIG_ENV_IS_IN_SPI_FLASH -#define CONFIG_SPI_FLASH
-#ifdef CONFIG_SPI_FLASH -#define CONFIG_EXYNOS_SPI -#define CONFIG_CMD_SF -#define CONFIG_CMD_SPI -#define CONFIG_SPI_FLASH_WINBOND -#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0 -#define CONFIG_SF_DEFAULT_SPEED 50000000 -#define EXYNOS5_SPI_NUM_CONTROLLERS 5 -#endif
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH -#define CONFIG_ENV_SPI_MODE SPI_MODE_0 -#define CONFIG_ENV_SECT_SIZE CONFIG_ENV_SIZE -#define CONFIG_ENV_SPI_BUS 1 -#define CONFIG_ENV_SPI_MAX_HZ 50000000 -#endif
- /* Ethernet Controllor Driver */ #ifdef CONFIG_CMD_NET #define CONFIG_SMC911X
Planning to apply this. Please comment Inder.
Any inputs on this patch - was not directly apply on master. Let me know this changes are still require - if yes, please sent the relevant patch again,
In samsung tree, this patch does not need any more because another patch was fixed this issue. Please ignore this patch.
Thanks, Minkyu Kang.