Re: [U-Boot] [PATCH v2] display_buffer: fix misaligned buffer

8 Sep 2010


      On Tuesday, September 07, 2010 19:33:38 Wolfgang Denk wrote:
...
Reinhard Meyer wrote:
...
for (i = 0; i < linelen * width; i++)


	if (!isprint(ucp[i]) || ucp[i] >= 0x80)


		ucp[i] = '.';


ucp[i] = '\0';


printf("    %s\n", ucp);


	if (!isprint(lb.uc[i]) || lb.uc[i] >= 0x80)


		lb.uc[i] = '.';


Please fix this old bug: the multi-line statement needs braces.
which bug ?  the logic is:
    for (...)
    	if (...)
    		... = ...;
you want the for loop to have explicit braces ?
    for (...) {
    	if (...)
    		... = ...;
    }
which would make it a style "bug", and not a code bug
-mike

Re: [U-Boot] [PATCH v2] display_buffer: fix misaligned buffer

Mike Frysinger