On Sun, Feb 25, 2018 at 2:54 AM, Wolfgang Denk wd@denx.de wrote:
Dear Duncan,
In message 20180224223615.14584-1-DH@synoia.com you wrote:
This code has passed through patman.
Oh, do you really think this is a good description of what this patch does? You can do better, I bet.
Hi Duncan,
I think you need to include comments about the patch that you would like to convey about it in the email, but not in the commit log in git, in the Commit-notes: section for patman to find.
From the patman README:
Commit-notes: blah blah blah blah more blah blah END Similar, but for a single commit (patch). These notes will appear immediately below the --- cut in the patch file. <<<<
Outside of that section, you need to include a detailed description of what the patch does and why. This is what Wolfgang is expecting to see.
Thanks, -Joe
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Faith may be defined briefly as an illogical belief in the occurence of the improbable. - H. L. Mencken _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot