Hi Yinbo,
-----Original Message----- From: York Sun Sent: Wednesday, August 8, 2018 6:09 AM To: Yinbo Zhu yinbo.zhu@nxp.com; yorksun@freescale.com; u-boot@lists.denx.de Cc: Y.b. Lu yangbo.lu@nxp.com; Xiaobo Xie xiaobo.xie@nxp.com; Andy Tang andy.tang@nxp.com; Peng Ma peng.ma@nxp.com Subject: Re: [PATCH v4 1/8] armv8: enable BLK code configuration
On 08/06/2018 12:15 AM, Yinbo Zhu wrote:
This patch is to enable BLK code configuration for SD boot.
Signed-off-by: Yinbo Zhu yinbo.zhu@nxp.com
Change in v4: keep the same revision v4 for the entire set.
include/mmc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/mmc.h b/include/mmc.h index 534c317..66e69b7 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -604,7 +604,7 @@ struct mmc { u64 enh_user_start; u64 enh_user_size; #endif -#if !CONFIG_IS_ENABLED(BLK) +#if CONFIG_IS_ENABLED(BLK) struct blk_desc block_dev; #endif char op_cond_pending; /* 1 if we are waiting on an op_cond command
*/
You ignored my comment on your v3 patch. See it here http://patchwork.ozlabs.org/patch/945479/
[Y.b. Lu] MMC block reading should use blk_dread() now. The old function mmc->block_dev.block_read() would cause compile issue when CONFIG_BLK is enabled. Please generate patches to fix this in any driver which still used the old block read function.
You can refer to below patches. bcfde7f mmc: use block layer in mmc command c40fdca dm: mmc: Move the device list into a separate file
York