Re: [U-Boot] [RFC PATCH v2 15/15] bootstage: arm: Add bootstage calls in board and bootm

On Saturday 10 December 2011 16:08:07 Simon Glass wrote:

--- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c

static void announce_and_cleanup(void) { printf("\nStarting kernel ...\n\n");

• bootstage_mark_name(BOOTSTAGE_ID_BOOTM_HANDOFF, "start_kernel");

+#ifdef CONFIG_BOOTSTAGE_REPORT

• bootstage_report();

+#endif

shouldn't the header make bootstage_report() into a stub when CONFIG_BOOTSTAGE_REPORT isn't defined ? then you won't need the ifdef protection here. -mike