On Mon, May 16, 2016 at 05:47:43PM +0800, Miao Yan wrote:
2016-05-14 4:46 GMT+08:00 Tom Rini trini@konsulko.com:
On Fri, May 13, 2016 at 10:00:05PM +0800, Bin Meng wrote:
Hi Miao,
On Fri, May 13, 2016 at 2:29 PM, Miao Yan yanmiaobest@gmail.com wrote:
This patch is part of the qfw refactor work.
The qemu_fwcfg_free_files() function is only used in error handling in ACPI table generation, let's not make this a core function and move it to the right place.
But I suspect this API may still be needed in some other scenarioes? eg: for future ARM64 ACPI?
Yes, as it stands currently the code looks likely useful for non-x86 QEMU+ACPI.
ARM64 and x86 should be able to share common ACPI code. As for now, this function is not used anywhere but error handling in only one place. I'd prefer not to make this public.
Well, OK, I'm not going to argue too too hard here, but if someone duplicates this part of the qemu code since it wasn't in common, it's on you :)