On Thu, Sep 8, 2011 at 10:10 AM, Kridner, Jason jdk@ti.com wrote:
On Sep 8, 2011, at 11:03 AM, "Albert ARIBAUD" albert.u.boot@aribaud.net wrote:
Hi Joel,
Le 08/09/2011 16:56, Joel A Fernandes a écrit :
Also, I agree with Albert: there should be no need for a separate userbutton command.
Please fix and resubmit.
If this patch is to be dropped, then I'm not sure why the need to resubmit?
I gather the "resubmit" means "resubmit the patch set minus this patch and renumbered accordingly".
One thing that would be necessary is to replace the default bootcmd with one that uses the gpio command and to enable the gpio command.
Actually the functions in arch/arm/cpu/armv7/omap-common/gpio.c are not compatible with the ones used by common/cmd_led.c
What would be the right place to implement the required functions for the gpio command?
1. In the (beagle)board file as wrappers to the omap gpio functions 2. In the gpio.c file in omap-common 3. Any other option?
Thanks, Joel