On Mon, Aug 28, 2017 at 6:13 AM, Tom Rini trini@konsulko.com wrote:
On Mon, Aug 28, 2017 at 12:01:51PM +0100, Måns Rullgård wrote:
Simon Glass sjg@chromium.org writes:
This was broken by the recent environment refactoring. Specifically:
$ make environ scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop. make: *** [Makefile:1469: environ] Error 2
Fix this by updating the Makefile and adjusting the #include filesnames in two C files.
Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ') Reported-by: Måns Rullgård mans@mansr.com Signed-off-by: Simon Glass sjg@chromium.org
This still breaks any build scripts using the old target (yes, there are many). That's probably acceptable, but a mention of it in some release note would be nice.
Come to think of it, if we're anyway going to break things, how about giving that target a more descriptive name than environ? I suggest envtools.
Too early, no coffee. Can't we do some make logic so that 'env' is still a target and thus we don't break those scripts? Otherwise, yes, I'll make sure to indicate in at least the v2017.09 release email that we renamed 'env' to envtools or something. Thanks!
It's really just building the fw_printenv tool (which uses a symlink for fw_setenv). It seems like a much clearer make target, and source dir for that matter, would be fw_printenv.
-Joe