On Tuesday, December 07, 2010 16:51:41 Wolfgang Denk wrote:
Mike Frysinger wrote:
hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it boils down to default values when the env var is not set. some places interpret this to mean "yes" while others expect "no". getenv_yesno() takes the "no" default which doesnt always work.
In addition to the default values, there is the difference that the documentation states that "autostart" has to be set to "yes", i. e. a plain "y" is not supposed to mean 'yes'.
consider it an enhancement then ? i dont see a problem with making the values fuzzier. personally, i make funcs like this accept any of the common strings such as true/false/0/1/y/n/yes/no.
i can update the API to take a 2nd arg (the default value), or we can punt this patch. it's in "next", so there's less pressure to get it fixed immediately ...
I think the easiest way to fix this is to revert the commit.
it's in "next", so it could even just be dropped -mike