Hi Niklaus,
On Wednesday 04 April 2007 15:30, Niklaus Giger wrote:
@@ -213,7 +213,7 @@ int do_bootvx (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) (char *) bootaddr); printf ("## Starting vxWorks at 0x%08lx ...\n", addr);
((void (*)(void)) addr) ();
((void (*)(int)) addr) (2); /* 0 => BOOT_NORMAL 2=> BOOT_CLEAR*/
puts ("## vxWorks terminated\n"); return 1;Are you sure that this parameter is supported. A quick "googling" only showed this parameter in the VxWorks function reboot(), and I don't think this is the entry point of the VxWorks image.
It is also used by the function void usrInit (int startType) and gets passed afterward to various init functions, e.g. usrBootLineInit. My board specific code tested its value, which made me discover this bug.
OK, thanks for clarifying.
Could you then please resubmit a new patch with a poper git commit description and a signed-off line. And please don't use "2" (BOOT_CLEAR) as default here. Default should be "0" (BOOT_NORMAL). Perhaps you could make it configurable via an env variable?
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany =====================================================================