OK. I was waiting to see if Simon's dm display driver changes would go in via the Tegra repo (they apply / build OK now, but I've had no time for testing).
With the merge window closing, I'll send a PR with just this fix. Thanks.
Tom
-----Original Message----- From: Stephen Warren [mailto:swarren@wwwdotorg.org] Sent: Thursday, January 28, 2016 10:11 AM To: Tom Warren TWarren@nvidia.com Cc: u-boot@lists.denx.de; Simon Glass sjg@chromium.org; Stephen Warren swarren@nvidia.com; Thierry Reding treding@nvidia.com Subject: Re: [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming
On 01/18/2016 12:16 PM, Tom Warren wrote:
Stephen Warren wrotea tMonday, January 18, 2016 11:23 AM:
The PMIC is configured such that its GPIOs have the correct configuration at power-up, so no programming is required.
In fact, the current programming is actively wrong, since:
(a) the AS3722 driver configures the GPIO to be an output before setting its output value, which causes a 0v glitch on the output.
(b) the AS3722 driver configures the GPIO to drive a high voltage from its VSUP_GPIO power source rather than its VDD_GPIO_LV power source, so the pin drives 5V not 1.8V as desired.
Solve these problems by removing the code which configures the PMIC
GPIOs.
Note that this patch was tested directly on top of v2016.01; since then, commit 96350f729c42 "dm: tegra: net: Convert tegra boards to driver model for Ethernet" prevents PCIe from being initialized. Alternatively, simply revert that commit to get PCIe Ethernet working again, then apply
this patch to test.
Acked-by: Tom Warren twarren@nvidia.com I'll apply this to u-boot-tegra/next ASAP.
I don't see this patch there yet. It'd be good to get it pulled upstream ASAP since the merge window for v2016.03 closes this weekend.
----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------