On 08/15/2012 11:30 PM, Stefan Roese wrote:
Hi Tom,
On 08/15/2012 11:30 PM, Tom Rini wrote:
The following patch series merges the davinci and omap-common SPL frameworks into a single framework, CONFIG_SPL_FRAMEWORK along with a few small cleanups to the code to make it a little smaller and more flexible. The end result is that davinci can now opt in on SPL-boots-Linux by just setting the right defines and other platforms would just need to adapt to this framework. In my testing, davinci gains between 300 and 700 bytes for this (not enabling the SPL OS feature) and omap4/5/etc lose just a little bit (from the printf->puts changes). I've tested this on omap3_beagle (xM and classic) and omap4_panda. I don't have any davinci platforms that were previously using SPL so I can't boot-test those changes but since everyone sets CONFIG_SPL_MAX_SIZE, we're OK in that department.
To make this series easier to test I've placed it on http://github.com/trini/u-boot WIP/spl-improvements
I've looked a little into re-reducing the size and the biggest problem I see is that SPI a lot of informational prints that we don't need, strictly speaking, but are nice in a normal U-Boot context. I'm unsure of the best way to quiet these as I don't like the idea of sprinkling #ifndef CONFIG_SPL_BUILD in random places.
Making SPL more generic is great. So moving these files out of the omap-common directory is the way to go. But your approach moves them to arch/arm/lib, restricting it only to ARM. Wouldn't it be possible to move it into an even more common location, so that other archs may also benefit from it?
I'm asking, since I'm currently working on an PowerPC based board which shall also use the SPL OS booting feature (Falcon boot).
Are the files ARM specific (I'm just starting looking into them right now)?
In theory, these should be fine on other arches. I'm just hesitant to call these common and put them in common/ without someone else doing the work of making sure they really are usable elsewhere. Sounds like about now would be the time to try, so for v2 I can move them to common/spl.c common/spl_ymodem.c and drivers/mmc/spl_mmc.c (to match drivers/mtd/nand/nand_spl* and drivers/mtd/spi/spi_spl*).