Re: [U-Boot] [PATCH 6/6] usb:g_dnl: Support for g_dnl download usb gadget for TRATS board

Dear Lukasz Majewski,

In message 1334215049-20362-7-git-send-email-l.majewski@samsung.com you wrote:

Signed-off-by: Lukasz Majewski l.majewski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com

See comments as for GONI board.

+#ifdef CONFIG_USBDOWNLOAD_GADGET +void usbd_thor_udc_probe(void) +{

• puts("USB_udc_probe\n");
• s3c_udc_probe(&s5pc210_otg_data);

+} +#endif

Duplicated code. Please move to common location and avoid duplication.

Best regards,

Wolfgang Denk