Re: [U-Boot] [PATCH 3/4 v2] UBIFS: Change ubifsload to not read beyond the requested size

Dear Stefan Roese,

In message 1288628880-6910-1-git-send-email-sr@denx.de you wrote:

• 		/* Read block-size into temp buffer */
  

• 		ret = read_block(inode, buff, block, dn);
  

• 		if (ret) {
  

• 			err = ret;
  

• 			if (err != -ENOENT) {
  

• 				free(buff);
  

• 				break;
  

• 			}
  

• 		}
  

...

• 		ret = read_block(inode, addr, block, dn);
  

• 		if (ret) {
  

• 			err = ret;
  

• 			if (err != -ENOENT)
  

• 				break;
  

• 		}
  

I still wonder what's the logic behind this code. When will read_block() return -ENOENT (aka "No such file or directory") ? What are the other possible error conditions, and why would it make sense to continue reading after these other errors?

Best regards,

Wolfgang Denk