Re: [PATCH u-boot-marvell 3/3] arm: a37xx: pci: Update comment about Command/Direct mode

On 2/15/22 11:23, Pali Rohár wrote:

Code is changing PCIe controller from Command mode to Direct mode.

Signed-off-by: Pali Rohár pali@kernel.org

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan

---

drivers/pci/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c index c795ef10b884..4f7e61ecf166 100644 --- a/drivers/pci/pci-aardvark.c +++ b/drivers/pci/pci-aardvark.c @@ -757,7 +757,7 @@ static int pcie_advk_setup_hw(struct pcie_advk *pcie) int i, wins; u32 reg;

• /* Set to Direct mode */

• /* Set from Command to Direct mode */ reg = advk_readl(pcie, ADVK_CORE_CTRL_CONFIG); reg &= ~ADVK_CORE_CTRL_CONFIG_COMMAND_MODE; advk_writel(pcie, reg, ADVK_CORE_CTRL_CONFIG);

Viele Grüße, Stefan Roese