Dear Stefan Roese,
In message 1244559423-15020-1-git-send-email-sr@denx.de you wrote:
This patch adds NAND Flash Controller driver for MPC5121 revision 2. All device features, except hardware ECC and power management, are supported.
This NFC driver replaces the one orignally posted by John Rigby:
"[PATCH] Freescale NFC NAND driver"
It's a port of the Linux driver version posted by Piotr Ziecik a few weeks ago. Using this driver has the following advantages (from my point of view):
- Compatibility with the Linux NAND driver (e.g. ECC usage)
- Better code quality in general
- Resulting U-Boot image is a bit smaller (approx. 3k)
- Better to sync with newer Linux driver versions
The only disadvantage I can see, is that HW-ECC is not supported right now. But this could be added later (e.g. port from Linux driver after it's supported there). Using HW-ECC on the MCP5121 NFC has a general problem because of the ECC usage in the spare area. This collides with JFFS2 for example.
Signed-off-by: Stefan Roese sr@denx.de Cc: Piotr Ziecik kosmo@semihalf.com Cc: Wolfgang Denk wd@denx.de Cc: John Rigby jcrigby@gmail.com Cc: Scott Wood scottwood@freescale.com
v3:
- Reworked chip-select routines after testing on MPC5121ADS with 2 NAND chips. Tested successfully on MPC5121ADS and esd MECP5123.
v2:
- Added (C) for myself
- Reduced line length of commit text
- Fixed spelling error in commit text
- chip select function is implemented as weak default so that board may implement a board specific variant (e.g. MPC5121ADS)
drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/mpc5121_nfc.c | 692 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 693 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/nand/mpc5121_nfc.c
Applied to u-boot-mpc5xxx repo, thanks.
Best regards,
Wolfgang Denk