Dear Prafulla Wadaskar,
In message 1249583526-22532-1-git-send-email-prafulla@marvell.com you wrote:
This feature can be used to trigger special command "sysrst_cmd" using reset key long press event (useful for reset to factory or manufacturing mode execution)
Cool.
Implementation: upon long reset assertion (> 5secs) sysrst_cmd will be executed if pre-defined in environment variables
I like the feature, but I don't like the hardwired timeout value.
+#ifndef CONFIG_SYS_RST_THRESHOLD_TIME +#define CONFIG_SYS_RST_THRESHOLD_TIME 5 +#endif /* CONFIG_SYS_RST_THRESHOLD_TIME */
Could you please use an environment variable for this, i. e. "sysrstcmd" and "sysrstdelay" (note that I omitted the underscore, too, because it looks ugly to me). This goes more in line with existing definitions like "bootcmd" and "bootdelay".
Thanks.
Best regards,
Wolfgang Denk