Re: [U-Boot] [PATCH 2/2] efikamx: update and clean up configuration

On 23/08/2012 16:52, Matt Sealey wrote:

Rewrite and refine the configuration for the Efika MX to support the board features effectively.

In summary:

• Reorder configuration so it is more readable
• Bring the configuration up to a production-compatible boot process by implementing scanning of bootable partitions on MMC and ATA media, and the environment required to support this.
• Refine configuration settings to save space and disable arguably unused features like gzip support (not required for booting).
• Add CONFIG_EFI_PARTITION, CONFIG_OF_FDT and CONFIG_CMD_BOOTZ support.
• Refine memtest ranges
• Remove SPI flash environment saving since modifying the environment can stop boot, and in any case can be modified or supplemented from any supported boot media via the "boot.scr" script or through the serial console each boot.
• USB default to port 0 which is the Smarttop USBDR port (Ethernet)
• Make CONFIG_CMD_NET 'depend' on CONFIG_CMD_USB (CONFIG_CMD_USB is not currently optional, though, but it makes more sense this way)
• Remove CONFIG_PREBOOT and CONFIG_USB_KEYBOARD

Requires the patch "Add U_BOOT_TIMESTAMP definition."

Signed-off-by: Matt Sealey matt@genesi-usa.com Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de

---

Matt,

there are no issue with this patch, but checkpatch reports errors. Can you fix them and resubmit, please ?

Regards, Stefano Babic