On Tuesday 06 November 2007, Michael Schwingen wrote:
Wouldn't it be better not to remove those unused fields? This way porting of new devices from Linux to U-Boot would be easier.
Right. I was concerned about the size of the table - the complete table from Linux contains *lots* of devices and may take up quite some space, so stripping out unused fields should help a bit. If there is a consensus to keep the fields to ease porting new parts, that is fine with me.
I vote for keeping the fields in. From my point of view, it's better to only enable a small part of the available FLASH definitions, than to strip some fields from the struct and make porting more difficult.
I think in the future we may need some ifdefs in the table to select sub-sets of supported parts - if a board has a 29LV040, it is useful to have support for other flash ROMS with similar layout and pinout that may be used as alternatives, but completely different parts (eg. 29LV160) may be left out.
ACK.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================