27 Jun
2012
27 Jun
'12
8:47 a.m.
Dear Nobuhiro Iwamatsu,
In message CABMQnV+RAOvBXAgnMv9Vo2HYjqZ7uZ2-TOx91qAYNrWX4PQM_Q@mail.gmail.com you wrote:
...
--- /dev/null +++ b/board/kmc/kzm/lowlevel_init.S
...
and_write32 LIFEC_SEC_SRC, 0xFFFFFFE7and_write32 SRCR3, 0xFFFF7FFFand_write32 SMSTPCR2,0xFFFBFFFFand_write32 SRCR2, 0xFFFBFFFFwrite32 PLLECR, 0x00000000cmp_loop PLLECR, 0x00000F00, 0x00000000cmp_loop FRQCRB, 0x80000000, 0x00000000write32 PLL0CR, 0x2D000000write32 PLL1CR, 0x17100000write32 FRQCRB, 0x96235880cmp_loop FRQCRB, 0x80000000, 0x00000000write32 FLCKCR, 0x0000000Band_write32 SMSTPCR0, 0xFFFFFFFDand_write32 SRCR0, 0xFFFFFFFDwrite32 SMGPIOTIME, 0x00000514write32 SMCMT2TIME, 0x00000514write32 SMCPGTIME, 0x00000514write32 SMSYSCTIME, 0x00000514write32 DVFSCR4, 0x00092000write32 DVFSCR5, 0x000000DCwrite32 PLLECR, 0x00000000cmp_loop PLLECR, 0x00000F00, 0x00000000write32 FRQCRA, 0x0012453Cwrite32 FRQCRB, 0x80331350cmp_loop FRQCRB, 0x80000000, 0x00000000write32 FRQCRD, 0x00000B0Bcmp_loop FRQCRD, 0x80000000, 0x00000000write32 PCLKCR, 0x00000003write32 VCLKCR1, 0x0000012Fwrite32 VCLKCR2, 0x00000119write32 VCLKCR3, 0x00000119write32 ZBCKCR, 0x00000002write32 FLCKCR, 0x00000005write32 SD0CKCR, 0x00000080write32 SD1CKCR, 0x00000080write32 SD2CKCR, 0x00000080write32 FSIACKCR, 0x0000003Fwrite32 FSIBCKCR, 0x0000003Fwrite32 SUBCKCR, 0x00000080write32 SPUACKCR, 0x0000000Bwrite32 SPUVCKCR, 0x0000000Bwrite32 MSUCKCR, 0x0000013Fwrite32 HSICKCR, 0x00000080write32 MFCK1CR, 0x0000003Fwrite32 MFCK2CR, 0x0000003Fwrite32 DSITCKCR, 0x00000107write32 DSI0PCKCR, 0x00000313write32 DSI1PCKCR, 0x0000130Dwrite32 DSI0PHYCR, 0x2A800E0Ewrite32 PLL0CR, 0x1E000000write32 PLL0CR, 0x2D000000write32 PLL1CR, 0x17100000write32 PLL2CR, 0x27000080write32 PLL3CR, 0x1D000000write32 PLL0STPCR, 0x00080000write32 PLL1STPCR, 0x000120C0write32 PLL2STPCR, 0x00012000write32 PLL3STPCR, 0x00000030write32 PLLECR, 0x0000000Bcmp_loop PLLECR, 0x00000B00, 0x00000B00write32 DVFSCR3, 0x000120F0write32 MPMODE, 0x00000020write32 VREFCR, 0x0000028Awrite32 RMSTPCR0, 0xE4628087write32 RMSTPCR1, 0xFFFFFFFFwrite32 RMSTPCR2, 0x53FFFFFFwrite32 RMSTPCR3, 0xFFFFFFFFwrite32 RMSTPCR4, 0x00800D3Dwrite32 RMSTPCR5, 0xFFFFF3FFwrite32 SMSTPCR2, 0x00000000write32 SRCR2, 0x00040000and_write32 PLLECR, 0xFFFFFFF7cmp_loop PLLECR, 0x00000800, 0x00000000write32 HPBCTRL6, 0x00000001cmp_loop HPBCTRL6, 0x00000001, 0x00000001write32 FRQCRD, 0x00001414cmp_loop FRQCRD, 0x80000000, 0x00000000write32 PLL3CR, 0x1D000000or_write32 PLLECR, 0x00000008cmp_loop PLLECR, 0x00000800, 0x00000800or_write32 DLLCNT0A, 0x00000002write32 SDGENCNTA, 0x00000005cmp_loop SDGENCNTA, 0xFFFFFFFF, 0x00000000write32 SDCR0A, 0xACC90159write32 SDCR1A, 0x00010059write32 SDWCRC0A, 0x50874114write32 SDWCRC1A, 0x33199B37write32 SDWCRC2A, 0x008F2313write32 SDWCR00A, 0x31020707write32 SDWCR01A, 0x0017040Awrite32 SDWCR10A, 0x31020707write32 SDWCR11A, 0x0017040Awrite32 SDDRVCR0A, 0x05555555write32 SDWCR2A, 0x30000000or_write32 SDPCRA, 0x00000080cmp_loop SDPCRA, 0x00000080, 0x00000080write32 SDGENCNTA, 0x00002710cmp_loop SDGENCNTA, 0xFFFFFFFF, 0x00000000write32 SDMRACR0A, 0x0000003Fwrite32 SDMRA1, 0x00000000write32 SDGENCNTA, 0x000001F4cmp_loop SDGENCNTA, 0xFFFFFFFF, 0x00000000write32 SDMRACR0A, 0x0000FF0Awrite32 SDMRA3, 0x00000000write32 SDGENCNTA, 0x00000032cmp_loop SDGENCNTA, 0xFFFFFFFF, 0x00000000write32 SDMRACR0A, 0x00002201write32 SDMRA1, 0x00000000write32 SDMRACR0A, 0x00000402write32 SDMRA1, 0x00000000write32 SDMRACR0A, 0x00000403write32 SDMRA1, 0x00000000write32 SDMRA2, 0x00000000write32 SDMRTMPCRA, 0x88800004write32 SDMRTMPMSKA,0x00000004write32 RTCORA, 0xA55A0032write32 RTCORHA, 0xA55A000Cwrite32 RTCSRA, 0xA55A2048or_write32 SDCR0A, 0x00000800or_write32 SDCR1A, 0x00000400write32 ZQCCRA, 0xFFF20000or_write32 DLLCNT0B, 0x00000002write32 SDGENCNTB, 0x00000005cmp_loop SDGENCNTB, 0xFFFFFFFF, 0x00000000write32 SDCR0B, 0xACC90159write32 SDCR1B, 0x00010059write32 SDWCRC0B, 0x50874114write32 SDWCRC1B, 0x33199B37write32 SDWCRC2B, 0x008F2313write32 SDWCR00B, 0x31020707write32 SDWCR01B, 0x0017040Awrite32 SDWCR10B, 0x31020707write32 SDWCR11B, 0x0017040Awrite32 SDDRVCR0B, 0x05555555write32 SDWCR2B, 0x30000000or_write32 SDPCRB, 0x00000080cmp_loop SDPCRB, 0x00000080, 0x00000080write32 SDGENCNTB, 0x00002710cmp_loop SDGENCNTB, 0xFFFFFFFF,> 0x00000000write32 SDMRACR0B, 0x0000003Fwrite32 SDMRB1, 0x00000000write32 SDGENCNTB, 0x000001F4cmp_loop SDGENCNTB, 0xFFFFFFFF, 0x00000000write32 SDMRACR0B, 0x0000FF0Awrite32 SDMRB3, 0x00000000write32 SDGENCNTB, 0x00000032cmp_loop SDGENCNTB, 0xFFFFFFFF, 0x00000000write32 SDMRACR0B, 0x00002201write32 SDMRB1, 0x00000000write32 SDMRACR0B, 0x00000402write32 SDMRB1, 0x00000000write32 SDMRACR0B, 0x00000403write32 SDMRB1, 0x00000000write32 SDMRB2, 0x00000000write32 SDMRTMPCRB, 0x88800004write32 SDMRTMPMSKB, 0x00000004write32 RTCORB, 0xA55A0032write32 RTCORHB, 0xA55A000Cwrite32 RTCSRB, 0xA55A2048or_write32 SDCR0B, 0x00000800or_write32 SDCR1B, 0x00000400write32 ZQCCRB, 0xFFF20000or_write32 SDPDCR0B, 0x00030000write32 DPHYCNT1B, 0xA5390000write32 DPHYCNT0B, 0x00001200write32 DPHYCNT1B, 0x07CE0000write32 DPHYCNT0B, 0x00001247cmp_loop DPHYCNT2B, 0xFFFFFFFF, 0x07CE0000and_write32 SDPDCR0B, 0xFFFCFFFFwrite32 FRQCRD, 0x00000B0Bcmp_loop FRQCRD, 0x80000000, 0x00000000Can't all this be simplified by using tables?
I like this style. Because the information of the register is because it can be formed from a data sheet automatically. It is very painful to make a table from a data sheet separately. However, I obey it if a policy of ARM is to use the table.
I disagree. You cannot really like this style.
Such a list of completely hard-coded magic numbers, without any comments, is not readable and not maintainable. No programmer can like such code. It is a horrible mess.
I wonder why this is written in assembly at all? Why don't you write all this in C? I cannot see any strong reason that would prevent an implementation in C.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Make it right before you make it faster.