On 8/29/07, Wolfgang Denk wd@denx.de wrote:
From the following discussion [see thread "RFC: generic property fixup mechanism for LIBFDT"] I got the impression that an improved implementation is not available yet, so it will have to wait for the next release.
Do you agree to include this patch (which fixes a few build problems) into the current release and clean it up in the next one?
I'm confused. What build problems does it solve? As far as I can tell, this patch only adds support for CONFIG_OF_LIBFDT, but it leaves the old code alone. What am I missing?
As it stands, I don't like this patch. It seems rather schizophrenic to me by adding the new mechanism (CONFIG_OF_LIBFDT) without removing the old one (CONFIG_OF_FLAT_TREE). I don't see any advantage to keeping both mechanisms around. I'd rather see the patch switch entirely to the new method.
Cheers, g.