Nits: %s/Emable/Enable/
On 01.01.25 23:08, Simon Glass wrote:
Enable this command for x86 boards as it is quite useful for seeing where memory is.
Signed-off-by: Simon Glass sjg@chromium.org
Enabling the option by default for the sandbox in cmd/Kconfig and for x86 in arch/Kconfig is confusing. Please, use the same approach for all concerned architectures.
Why do we need symbol CMD_MEMINFO_MAP? The meminfo command is worthless without it. Both the greeting header and bdinfo already show the memory size. Can we remove that over-engineering?
Sending standalone patches separately from a bulky patch series would avoid hesitation to review and merge (see Tom's mail).
Best regards
Heinrich
arch/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig index 6258788f53f..2fb247d04b3 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -310,6 +310,8 @@ config X86 imply SYSINFO if GENERATE_SMBIOS_TABLE imply SYSINFO_SMBIOS if GENERATE_SMBIOS_TABLE imply TIMESTAMP
imply CMD_MEMINFO
imply CMD_MEMINFO_MAP
# Thing to enable for when SPL/TPL are enabled: SPL imply SPL_DM