On Tue, Oct 15, 2013 at 12:46 PM, Hector Palacios hector.palacios@digi.com wrote:
Dear Jagan,
On 10/14/2013 06:57 PM, Jagan Teki wrote:
On Mon, Oct 14, 2013 at 9:37 PM, Tom Rini trini@ti.com wrote:
On Mon, Oct 14, 2013 at 06:00:20PM +0200, Hector Palacios wrote:
Dear Marek,
I noticed that 'fatls' displays duplicated filenames (short and long) for every file in the media:
# fatls mmc 0 2083460 uimage-myplatform 2083460 uimage~1 1520 rootfs-dummy.jffs2 1520 rootfs~1.jff 3294952 uimage 3294952 uimage
The guilty commit is ff04f6d1224d8952b566b8671222151495883073 by you, who moved the chksum calculation out of an if() and now the code never enters this:
#ifdef CONFIG_SUPPORT_VFAT else if (dols == LS_ROOT && csum == prevcksum) { prevcksum = 0xffff; dentptr++; continue; } #endif
Could you please check?
Can you please provide more details about your platform and what U-Boot rev you see this on exactly? I haven't seen anything like this on Beaglebone Black recently, for example.
This kind of issue we faced(by Michal)
http://u-boot.10912.n7.nabble.com/FAT-problem-with-new-mkcksum-implementatio...
Where the issue got resolved with the change from Marek "vfat: Fix mkcksum argument sizes" (sha: 6ad77d88e57f6ab815ec7e85c5ac329054318c73)
I was testing on v2013.01. This patch fixes it. Thank you.
Does this means master still have an issue?