Re: [U-Boot] [PATCH] e1000: fix bugs from recent commits

Dear Mike Frysinger,

In message CAJaTeTpeNDdV4g+n4cE0GVe8uBxgjUdRhrF2t=q-pOb5pAmfzg@mail.gmail.com you wrote:

On Fri, Oct 28, 2011 at 07:49, Wolfgang Denk wrote:

...

--- a/drivers/net/e1000.h +++ b/drivers/net/e1000.h

#define E1000_WRITE_FLUSH(a) \

•   do { uint32_t x = E1000_READ_REG(a, STATUS); } while (0)
  

•   E1000_READ_REG(a, STATUS)
  

i think we want the do{}while as this is a write command and we don't want people accidentally trying to check the return value

I don't see that this is a write command. I'm seeing only reading of the status register here.

And I don't understand the "accidentally trying to check the return value" argument either. Why would one do that - and if one does (probably after checking the implementation), what would be wrong about it?

Best regards,

Wolfgang Denk