25 Apr
2011
25 Apr
'11
4:19 a.m.
-----Original Message----- From: vapierfilter@gmail.com [mailto:vapierfilter@gmail.com] On Behalf Of Mike Frysinger Sent: Saturday, April 23, 2011 4:54 AM To: Xie Shaohui-B21989 Cc: u-boot@lists.denx.de; Gala Kumar-B11780; Zang Roy-R61911; Hu Mingkai- B21284 Subject: Re: [PATCH 1/2][v3] powerpc: eSPI and eSPI controller support
On Fri, Apr 22, 2011 at 4:30 AM, Shaohui Xie wrote:
--- a/include/spi.h +++ b/include/spi.h
/*--------------------------------------------------------------------
- Representation of a SPI slave data.
- div16: whether System clock/16 is the input to the eSPI BRG.
- pm: Prescale modulus select.
- mode: Clock polarity, clock phase and other parameters.
- cmd_len: CMD length stored at BEGIN phase.
- cmd_buf: CMD stored at BEGIN phase.
- data_len: data length used to activate CS length.
- */
+struct spi_slave_data {
- unsigned int div16;
- unsigned int pm;
- unsigned int mode;
- size_t cmd_len;
- u8 cmd_buf[16];
- size_t data_len;
+};
err, this belongs in your spi controller code, not the common spi header. look at like the bfin_spi driver to see how to do it.
[Xie Shaohui] OK, Thanks, I see the bfin_spi driver; I'll take it as an example.
Best Regards, Shaohui Xie