Hi Lukasz Majewski,
2011/7/5 Lukasz Majewski l.majewski@samsung.com:
Included commits provide Linux USB gadget support for U-boot. The USB Gadget infrastructure is running on top of the Samsung's UDC OTG controller. The code has been tested on the GONI (S5PC110) reference target.
It's very happy to see there is a port of USB OTG from Linux framework. However, please remind that according to the patch rules on u-boot's wiki page: http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign Include git commit hash number and kernel version which you grabbed the code from it.
I've found that you're using the #define marco to represent registers. I'm not sure it you're using automatically generated asm-offsets.h method to manage these registers. However, it's better to rewrite it into structure form whihc is easier to read and maintain both in u-boot and in Linux.
If there are implemented the same way in Linux kernel, I suggest you could also improve it in Linux kernel and send cosmetic patches.