
15 Sep
2014
15 Sep
'14
7:25 p.m.
On Monday, September 15, 2014 at 06:00:47 PM, Dinh Nguyen wrote:
On 09/15/2014 06:05 AM, Marek Vasut wrote:
From: Pavel Machek pavel@denx.de
The dw_mmc driver was responding to errors with debug(). Change that to prinf()/puts() respectively so that any errors are immediately obvious. Also adjust english in comments.
[...]
@@ -290,7 +292,7 @@ static void dwmci_set_ios(struct mmc *mmc)
struct dwmci_host *host = (struct dwmci_host *)mmc->priv; u32 ctype, regs;
- debug("Buswidth = %d, clock: %d\n",mmc->bus_width, mmc->clock);
- debug("Buswidth = %d, clock: %d\n", mmc->bus_width, mmc->clock);
Did you intend to use printf here also? Or just fix up the spacing around mmc->bus_width?
This cannot be a printf(), since you would get an output upon every call of .set_ios(). This would generate a wall of text. So this is formatting fix.
Best regards, Marek Vasut