On Tue, Nov 04, 2014 at 07:58:38PM +0200, Igor Grinberg wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi Tom,
On 11/04/14 17:56, Tom Rini wrote:
On Sat, Nov 01, 2014 at 11:35:43AM +0100, Paul Kocialkowski wrote:
Some devices may use non-standard combinations of regulators to power MMC: this allows these devices to provide a board-specific MMC power init function to set everything up in their own way.
Signed-off-by: Paul Kocialkowski contact@paulk.fr
drivers/mmc/mmc.c | 8 ++++++++ include/mmc.h | 2 ++ 2 files changed, 10 insertions(+)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 44a4feb..125f347 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1277,6 +1277,12 @@ block_dev_desc_t *mmc_get_dev(int dev) } #endif
+/* board-specific MMC power initializations. */ +__weak int board_mmc_power_init(void) +{
- return -1;
+}
Since we don't check error return here which I think is fine just make this a void? Thanks!
There is v3 posted a while ago... We have also agreed on v4..
Yeah, oops, didn't delete these after catch-up. I'm still not sure we should continue adding more unchecked return values "just because".