Re: [PATCH v5 01/16] crypto/fsl: Add support for CAAM Job ring driver model

diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e43..2b24672505 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -2009,6 +2009,7 @@ config CMD_AES

config CMD_BLOB bool "Enable the 'blob' command"

• select FSL_BLOB

this looks wrong, because CMD_BLOB sounds like a generic command but it will automatically select FSL_BLOB which in turn sounds freescale specific. Looking at the help text, this command is (at least at the moment) freescale specific, but the code seems to be generic and the blob_encap() and blob_decap() are weak functions, thus they could be implemented in a different way and not just by fsl_blob.c.

I don't think this should automatically select FSL_BLOB.

Also, shouldn't this be an uclass with encap and decap ops?

depends on !MX6ULL && !MX6SLL && !MX6SL select IMX_HAB if ARCH_MX6 || ARCH_MX7 || ARCH_MX7ULP || ARCH_IMX8M help diff --git a/drivers/crypto/fsl/Kconfig b/drivers/crypto/fsl/Kconfig index 94ff540111..ab59d516f8 100644 --- a/drivers/crypto/fsl/Kconfig +++ b/drivers/crypto/fsl/Kconfig @@ -66,4 +66,11 @@ config FSL_CAAM_RNG using the prediction resistance flag which means the DRGB is reseeded from the TRNG every time random data is generated.

+config FSL_BLOB

•    bool "Enable Blob Encap/Decap, Blob KEK support"
  

wrong indendation?

• help

•  Enable support for the hardware based crytographic blob encap/decap
  

•  module of the CAAM. blobs can be safely placed into non-volatile
  

•  storage. blobs can only be decapsulated by the SoC that created it.
  

•  Enable support for blob key encryption key generation.
  

endif