Hello Heiko,
On Wed, 2014-01-29 at 10:04 +0100, Heiko Schocher wrote:
Maybe this site helps you:
http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign
Indeed I even went through this readme a while ago but didn't pay enough attention to it on submission.
The question is - if only some files in "arch/arc/include" are copies from Linux sources may I still have a cumulative patch with all arc headers and just list borrowed files in commit message or I need to put borrowed files in a separate patch?
Agree I forgot to mention which header files came from Linux kernel. Will add mentions.
diff --git a/arch/arc/include/asm/arch-arc700/hardware.h b/arch/arc/include/asm/arch-arc700/hardware.h new file mode 100644 index 0000000..e69de29
Empty file ?
Right, it looks weird, but I had to add this empty file just because of "designware_i2c" driver which refers to "asm/arch/hardware.h".
http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/i2c/designware_i2c.c;h=9ed...
And to remove "asm/arch/hardware.h" I would need to modify "arch/hardware.h" and "include/configs/..." files for platform/boards I don't own.
Basically this is just a work-around that allows me to use "designware_i2c" driver as it is.
There was a similar dependency ("asm/arch/clk.h") in "dw_mmc" but in that case it was possible to just remove it - what I did - http://git.denx.de/?p=u-boot.git;a=commit;h=ca6d4d0f8f0fb8ae09a7ba271177367b...
So if you insist on removal of this file we would need to fix "designware_i2c" first.
Please let me know what do you think about this item.
Hmm.. at least you should an comment in this file, why it is necessary.
Once again may I just mention it in commit message? Otherwise because of this mention in file itself I would need to add licensing (copyright) info in the file and then we have a file which only needs to exist to satisfy pre-processor but with contents of about 10 lines (which doesn't have any technical purpose).
Ok, hope to find time for your other patches ...
Much appreciated!
Thanks a lot, Alexey