Re: [U-Boot] [PATCH 25/38] arm: Add explicit include of <asm/mach-types.h>

On Wed, May 17, 2017 at 08:22:58AM -0600, Simon Glass wrote:

Rather than relying on common.h to provide this include, which is going away at some point, include it explicitly in each file.

Signed-off-by: Simon Glass sjg@chromium.org

[snip]

diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c index 8ff2c5065d..3ea494f5e4 100644 --- a/arch/arm/lib/spl.c +++ b/arch/arm/lib/spl.c @@ -12,6 +12,9 @@ #include <spl.h> #include <image.h> #include <linux/compiler.h> +#ifdef CONFIG_MACH_TYPE +#include <asm/mach-types.h> +#endif

We don't need to #ifdef this part here, we can safely always include this header.

You can repost just a v2 of this one with:

Reviewed-by: Tom Rini trini@konsulko.com

Thanks!