On Sat, Feb 08, 2020 at 04:47:08PM +0100, Soeren Moch wrote:
On 08.02.20 06:38, Denis 'GNUtoo' Carikli wrote:
The side effect is that it increase the size of the resultimg image, which is already very close to the size limit.
With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola GNU/Linux distribution, we have the following size increase:
- text: 8744 bytes
- data: 132 bytes
- bss: 60 bytes
- total: 8936 bytes
Signed-off-by: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
Thank you very much for splitting up the patches and for your thorough size analysis. This makes it very easy to understand the size contributions of the several parts.
It was really surprising for me that CONFIG_DISTRO_DEFAULTS brings so much additional text. I thought this would only enable CONFIG_CMD_SYSBOOT, but we also get PXE support. I wasn't aware of this before.
Distro boot brings in a ton of "support booting via any supported IO device" code.
That said, the "bring in PXE" part of DISTRO_DEFAULTS predates sysboot being pulled out of the PXE code, where it was historically introduced. I would like to see a patch to change this part, stand-alone and CC'ing the distribution folks that might have something to say about this. I know there are use-cases for it, but I don't know how critical they are to be everywhere by default vs opt-in. Thanks all!