Re: [U-Boot] [PATCH 4/4] ARM: sheevaplug: correct nand partition layout

...

...

...

...

"Tom" == Tom Rini trini@konsulko.com writes:

Hi,

...

#define CONFIG_EXTRA_ENV_SETTINGS "x_bootargs=console" \ "=ttyS0,115200 mtdparts="CONFIG_MTDPARTS \

• "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \

• "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x400000\0" \

"x_bootcmd_usb=usb start\0" \ "x_bootargs_root=root=/dev/mtdblock3 rw rootfstype=jffs2\0"

Can I suggest future proofing this by using the names set in MTDPARTS instead of direct offsets? Thanks!

True. I wanted to do as minimal change as possible, but I'll take a look at using mtdparts and send a patch.

Thanks.