On 01/23/15 11:47, Stefano Babic wrote:
Hi Nikita,
On 22/01/2015 18:33, Nikita Kiryanov wrote:
This is a general question, not strictly related to the patch. You add with the series a way to get splash screen from multiple sources. I have often (I know we are talking about different things..) used splash screen as a way to add a logo, without the necessity to link the image to the code. I think also that the way with logo does not scale well,
Why not?
Well, it happens if for each maintained board there is a corresponding logo and all logos should be maintain in U-Boot repository - that is quite a mess.
Right. I must agree it is a mess. Also, please understand correctly, this is not our intent...
Logos has nothing to do with U-Boot development - they are blob data. The fact that they are linked together with U-Boot looks easy, but I do not think it is elegant.
Splash images are loaded on demand by u-boot code from a storage - this is IMHO a better solution.
Yes, indeed, and also the only one that permits a board to have multiple customizable splash images - which is the case for many SoMs.
and we cannot merge in mainline tons of images - they have nothing to do with u-boot sources.
Storing graphics that are part of a program in the program's repository is a common practice, why should U-Boot be different?
Maybe due to the number of boards, and if each board wants to have its own logo. If all boards share the same logo I would not see any problem at all.
And yes, this is our intent. We would like to have a single logo for all our boards (and we have some already - more to come). It is vendor oriented, not board oriented.
Why is not enough for you to use the splash screen functionality ? IMHO it is much more flexible as using the logo, and there is no need to link it against the code.
We are interested in the behavior that VIDEO_LOGO provides: that the logo remains visible on screen and coexists with the frame buffer console, and that no manual installation is required.
ok, you like really the logo feature, I see ;-).
Yes, currently, it is used on Utilite computer (which is build around cm-fx6 SoM). So, it looks really good, for the Utilite users to have the HDMI with USB console and the vendor logo.
Added Anatolji to CC - we could let the question in background for the future. Maybe could we have a logo_load_image() near splash_load_from_*() ?
That would be perfect, I think, and also have it user customizable. Although, I would like to have an option to return to default one...