Re: [U-Boot] [PATCH v3 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114

On 06/17/2013 03:09 AM, Jim Lin wrote:

Add DT node for USB EHCI function. Add support for T30-Cardhu, T30-Beaver, T114-Dalmore boards.

This patch shouldn't touch both DT files and code at the same time. The code changes should be part of the patch to the USB driver.

diff --git a/board/nvidia/dts/tegra30-cardhu.dts b/board/nvidia/dts/tegra30-cardhu.dts

• usb@7d008000 {

• nvidia,vbus-gpio = <&gpio 233 3>;	/* PDD1, EN_3V3_PU */
  

• status = "okay";
  

• };

PDD1 is the wrong signal. That enables a 100L pullup to a bunch of different signals, including the VBUS GPIO. Instead, I think you should be using PEX_L1_PRSNT / EN_USB3_VBUS_OC / PDD4, which co-incidentally matches the value in the Beaver .dts file in this patch, most likely because Beaver is closely based on Cardhu.