-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Monday, June 07, 2010 5:55 PM To: Hiremath, Vaibhav Cc: u-boot@lists.denx.de; tom@bumblecow.com; Paulraj, Sandeep; Premi, Sanjeev Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
Dear "Hiremath, Vaibhav",
In message 19F8576C6E063C45BE387C64729E7394044E7A16B5@dbde02.ent.ti.com you wrote: ...
diff --git a/MAINTAINERS b/MAINTAINERS index 5cbc845..0bc65e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -798,6 +798,10 @@ Alex Z lart SA1100 dnp1110 SA1110
+Vaibhav Hiremath hvaibhav@ti.com
- am3517_evm ARM CORTEX-A8 (AM35x SoC)
Please keep list sorted.
[Hiremath, Vaibhav] How does this sorted, I could not see any relation between the entries there.
The list is sorted alphabetically by maintainer' last names, and then by CPU / board names.
[Hiremath, Vaibhav] Thanks, I will update the patch and submit is shortly.
diff --git a/arch/arm/include/asm/arch-omap3/mux.h
b/arch/arm/include/asm/arch-omap3/mux.h
index 0c01c73..ffeb982 100644 --- a/arch/arm/include/asm/arch-omap3/mux.h +++ b/arch/arm/include/asm/arch-omap3/mux.h
...
+/* AM3517 specific */ +#define CONTROL_PADCONF_CCDC_PCLK 0x01E4 +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6
Board specific defoinitions should not be added to global header files. Please use a board specific header instead.
[Hiremath, Vaibhav] I think this has been placed at the right place.
This is
mux definition and got added to mux.h file. You could see all mux
definition
are present in this file.
Do you see any issues with this?
Yes, as I wrote: board specific definitions should not be added to global header files. They should be added to board specific files only, avoiding the need for tons of #ifdef's in global files.
[Hiremath, Vaibhav] Yes I agree this has to be there in board header file, but I don't think we are using #ifdefs anywhere for this, since the usage of this is happening through board header file.
I am moving these definitions to board/logicpd/am3517evm/am3517evm.h file.
Thanks, Vaibhav
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de When you die, the first thing you lose is your life. The next thing is the illusions. - Terry Pratchett, _Pyramids_