Hi Ted,
On 1 December 2015 at 04:24, Ted Chen tedchen@realtek.com wrote:
This patch adds driver support for the Realtek RTL8152B/RTL8153 USB network adapters.
Signed-off-by: Ted Chen <tedchen at realtek.com> [swarren, fixed a few compiler warnings] [swarren, with permission, converted license header to SPDX] [swarren, removed printf() spew during probe()] Signed-off-by: Stephen Warren <swarren at nvidia.com>
drivers/usb/eth/Makefile | 1 + drivers/usb/eth/r8152.c | 1522 +++++++++++++++++++++++++++++++++++++++++++ drivers/usb/eth/r8152.h | 614 +++++++++++++++++ drivers/usb/eth/r8152_fw.c | 980 ++++++++++++++++++++++++++++ drivers/usb/eth/usb_ether.c | 7 + include/usb_ether.h | 6 + 6 files changed, 3130 insertions(+) create mode 100644 drivers/usb/eth/r8152.c create mode 100644 drivers/usb/eth/r8152.h create mode 100644 drivers/usb/eth/r8152_fw.c
Changes for v2: Modified by Marek's comments.
- Remove pattern informations.
- Don't allocate & free when read/write register.
- relpace udelay to mdelay.
- pull firmware into global variable.
- code review.
Changes for v3: Modified by Marek's and Joe's comments.
- Remove driver version informations.
- separate firmware code to individual file.
- split extensive defines to r8152.h.
- code review.
NAK from me. This should use driver model.
Please look at smsc95xx.c or asix.c for an example. Also this one:
http://patchwork.ozlabs.org/patch/549812/ http://patchwork.ozlabs.org/patch/549807/
Also I think you *only* need to support driver model, since you can require any new platforms to enable it for Ethernet.
Regards, Simon