Dear Simon Glass,
In message 1302642840-6958-1-git-send-email-sjg@chromium.org you wrote:
The SMSC95XX is a USB hub with a built-in Ethernet adapter. This adds support for this, using the USB host network framework.
TEST=usb start; bootp; tftp ...
Signed-off-by: Simon Glass sjg@chromium.org
drivers/usb/eth/Makefile | 1 + drivers/usb/eth/smsc95xx.c | 922 +++++++++++++++++++++++++++++++++++++++++++ drivers/usb/eth/usb_ether.c | 7 + 3 files changed, 930 insertions(+), 0 deletions(-) create mode 100644 drivers/usb/eth/smsc95xx.c
$ checkpatch ~/Mail/U-Boot/6365
WARNING: space prohibited between function name and open parenthesis '(' #497: FILE: drivers/usb/eth/smsc95xx.c:383: + debug ("MAC %02x:%02x:%02x:%02x:%02x:%02x\n",
ERROR: space prohibited before open square bracket '[' #498: FILE: drivers/usb/eth/smsc95xx.c:384: + eth->enetaddr [0], eth->enetaddr [1],
ERROR: space prohibited before open square bracket '[' #498: FILE: drivers/usb/eth/smsc95xx.c:384: + eth->enetaddr [0], eth->enetaddr [1],
ERROR: space prohibited before open square bracket '[' #499: FILE: drivers/usb/eth/smsc95xx.c:385: + eth->enetaddr [2], eth->enetaddr [3],
ERROR: space prohibited before open square bracket '[' #499: FILE: drivers/usb/eth/smsc95xx.c:385: + eth->enetaddr [2], eth->enetaddr [3],
ERROR: space prohibited before open square bracket '[' #500: FILE: drivers/usb/eth/smsc95xx.c:386: + eth->enetaddr [4], eth->enetaddr [5]);
ERROR: space prohibited before open square bracket '[' #500: FILE: drivers/usb/eth/smsc95xx.c:386: + eth->enetaddr [4], eth->enetaddr [5]);
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #822: FILE: drivers/usb/eth/smsc95xx.c:708: +static int smsc95xx_send(struct eth_device *eth, volatile void* packet,
ERROR: code indent should use tabs where possible #1046: FILE: drivers/usb/eth/usb_ether.c:49: + {$
WARNING: please, no spaces at the start of a line #1046: FILE: drivers/usb/eth/usb_ether.c:49: + {$
ERROR: code indent should use tabs where possible #1047: FILE: drivers/usb/eth/usb_ether.c:50: + .before_probe = smsc95xx_eth_before_probe,$
WARNING: please, no spaces at the start of a line #1047: FILE: drivers/usb/eth/usb_ether.c:50: + .before_probe = smsc95xx_eth_before_probe,$
ERROR: code indent should use tabs where possible #1048: FILE: drivers/usb/eth/usb_ether.c:51: + .probe = smsc95xx_eth_probe,$
WARNING: please, no spaces at the start of a line #1048: FILE: drivers/usb/eth/usb_ether.c:51: + .probe = smsc95xx_eth_probe,$
ERROR: code indent should use tabs where possible #1049: FILE: drivers/usb/eth/usb_ether.c:52: + .get_info = smsc95xx_eth_get_info,$
WARNING: please, no spaces at the start of a line #1049: FILE: drivers/usb/eth/usb_ether.c:52: + .get_info = smsc95xx_eth_get_info,$
ERROR: code indent should use tabs where possible #1050: FILE: drivers/usb/eth/usb_ether.c:53: + },$
WARNING: please, no spaces at the start of a line #1050: FILE: drivers/usb/eth/usb_ether.c:53: + },$
total: 11 errors, 7 warnings, 942 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile
Please make sure to read http://www.denx.de/wiki/U-Boot/CodingStyle and http://www.denx.de/wiki/view/U-Boot/Patches. Then clean up your patches, and resubmit. Thanks.
Best regards,
Wolfgang Denk