Stefan Roese wrote:
On Monday 29 October 2007, Jon Loeliger wrote:
On Mon, 2007-10-29 at 13:41, Larry Johnson wrote:
Would it be better to run Lindent on the original files, post those as changes, and then post a second patch with the new material?
In my opinion, yes, please.
Yes, please do the coding style cleanup first, and the "real" patch later in a separate commit. Otherwise it will very hard to make out your changes in the commit-diff.
BTW, I've noticed that the "Lindent -pcs" format is used inconsistently within files. Since I'm also making changes in Linux, it's hard to remember whether to type "foo(bar);" or "foo (bar);",
In my opinion, "foo (bar)" is bad style, and I prefer the Linux form, "foo(bar)".
This is my way of coding too. Mainly because I'm used to doing it this way and Linux uses it too. But I know that Wolfgang prefers the "other" style. My vote would be, when you really run Lindent on this file (or other), switch to the Linux style completely.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Thanks everyone for the suggests. I will split the cosmetic from the functional patches and resubmit for further comments.
Best regards, Larry