10 Apr
2014
10 Apr
'14
11:04 a.m.
On Thursday, April 10, 2014 at 10:49:56 AM, Adrian Cox wrote:
From: "Marek Vasut" marex@denx.de
Also, this USB_KBD_PDATA_SIZE should instead be called "USB_KBD_LS_REPORT_SIZE" [...] What worries me a bit is that 64-byte high-speed report, but I never saw a device that would generate those. This section 5.6 is also the only place that mentions the high-speed HID device report size limit.
How about renaming to USB_KBD_BOOT_REPORT_SIZE? We know that the keyboard report will be 8 bytes because we explicitly set the keyboard into boot protocol (Appendix B of HID 1.11: "The report may not exceed 8 bytes in length.").
Good point, thanks. A comment in the code about where this number '8' comes from would be nice.
Best regards, Marek Vasut