Re: [U-Boot] [PATCH] MIPS: tb0229: fix GCC 4.6 compile errors and warnings

Dear Daniel Schwierzeck,

In message 1323442731-12017-1-git-send-email-daniel.schwierzeck@googlemail.com you wrote:

Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@googlemail.com

This patch fixes the last broken board when running MAKEALL -a mips. This board was added by Wolfgang in 2004 and never had a real maintainer. If no one care about this board, I think it could be dropped.

Can you please split thisi nto two patches, one performing just the coding style cleanup, and the second one adding all the rest?

...

-int checkboard (void) +int checkboard(void) { printf("Board: TANBAC TB0229 ");

• printf("(CPU Speed %d MHz)\n", (int)CPU_CLOCK_RATE/1000000);

• printf("(CPU Speed %d MHz)\n", (int) CPU_CLOCK_RATE / 1000000);

When we touch this, would it then not make sense to switch to using print_mhz() instead?

• if (access_type == PCI_ACCESS_WRITE) *VR4131_PCICONFDREG = *data;

• } else {

• else *data = *VR4131_PCICONFDREG;

You are sure that we don;t need any I/O accessors / memory barriers here (and elsewhere) ?

Best regards,

Wolfgang Denk