On Saturday 26 April 2008, Dave Littell wrote:
Here goes (again):
Patch for AMCC Sequoia to remove the TLB Guarded attribute for SDRAM, and add the Guarded attribute for Internal Registers & OCM.
I still have a few issues with this patch:
- Signed-off-by line missing - Please use a descriptive subject for this patch, something like: "[PATCH] ppc4xx: Fix guarded bit in some Sequoia TLB entries" - Comments that should not be part of the commit text should go below the "---" line in the email. Please take a look at other patches sent to the list on how exactly this should be done. - And best would be to create two separate TLB entries, one for internal SRAM (OCM) with G cleared and one for internal registers with G set
I strongly suggest to work with the git tools to create and send patches. This makes life a lot easier for all of us.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================