Re: [U-Boot] [PATCH v2 16/21] hash: Add a flag to support saving hashes in the environment

Dear Simon Glass,

In message 1361379515-23802-17-git-send-email-sjg@chromium.org you wrote:

Some hashing commands permit saving the hash in an environment variable, and verifying a hash from there. But the crc32 command does not support this. In order to permit crc32 to use the generic hashing infrastructure, add a flag to select which behaviour to use.

<nitpick>

...

• /*

• * If environment variables are allowed, then we assume that 'dest'
  

• * is an environment variable, unless it starts with *, in which
  

• * case we assume it is an address. If not allowed, it ia always an
  

s/it ia/it is/

</nitpick>

What's the impact of these changes on the memory footprint?

Best regards,

Wolfgang Denk