27 Oct
2009
27 Oct
'09
10:27 p.m.
On Tue, Oct 27, 2009 at 12:02:34PM +0100, Wolfgang Denk wrote:
+#define CONFIG_SYS_FLASH_ERASE_TOUT (6*CONFIG_SYS_HZ) +#define CONFIG_SYS_FLASH_WRITE_TOUT (2*CONFIG_SYS_HZ)
This looks wrong to me. A timeout is a time, but CONFIG_SYS_HZ is a frequency, i. e. the inverse of a time. These don't mix.
We've been over this: http://lists.denx.de/pipermail/u-boot/2009-September/059961.html :-P
C values don't carry units, so you can't assume that multiplying a frequency by 6 means you want another frequency 6 times as fast.
Whether the timeout is supposed to be expressed in ticks or in some other unit such as milliseconds is another matter.
-Scott