19 Jan
2021
19 Jan
'21
2:46 a.m.
On 1/18/21 7:05 PM, Andre Przywara wrote:
The #ifdef CONFIG_xxxPWR conditionals were not working as expected, as string Kconfig symbols are always "defined" from the preprocessor's perspective. This lead to unnecessary calls to the GPIO routines, but also always added a half a second delay to wait for a SATA disk to power up. Many thanks to Peter for pointing this out!
Fix this by properly comparing the Kconfig symbols against the empty string. strcmp() would be nicer for this, but GCC does not optimise this away, probably due to our standalone compiler switches.
Ethernet still works, and the speed-up is welcome.
Tested-by: Samuel Holland samuel@sholland.org # Orange Pi WinPlus
Cheers, Samuel