Hi Sjoerd,
On 24 November 2014 at 09:21, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
On Mon, 2014-11-24 at 09:01 -0700, Simon Glass wrote:
Hi Sjoerd,
On 24 November 2014 at 08:15, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from the board configuration & device-tree
Signed-off-by: Sjoerd Simons sjoerd.simons@collabora.co.uk
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- include/configs/peach-pi.h | 2 -- 2 files changed, 7 deletions(-)
diff --git a/arch/arm/dts/exynos5800-peach-pi.dts b/arch/arm/dts/exynos5800-peach-pi.dts index 8aedf8e..2f9d2db 100644 --- a/arch/arm/dts/exynos5800-peach-pi.dts +++ b/arch/arm/dts/exynos5800-peach-pi.dts @@ -63,11 +63,6 @@ reg = <0x20>; compatible = "maxim,max98090-codec"; };
edp-lvds-bridge@48 {compatible = "parade,ps8625";reg = <0x48>;}; }; sound@3830000 {diff --git a/include/configs/peach-pi.h b/include/configs/peach-pi.h index 8a82402..ff31728 100644 --- a/include/configs/peach-pi.h +++ b/include/configs/peach-pi.h @@ -26,8 +26,6 @@ #define CONFIG_SYS_PROMPT "Peach-Pi # " #define CONFIG_IDENT_STRING " for Peach-Pi"
-#define CONFIG_VIDEO_PARADE
/* Display */ #define CONFIG_LCD
#ifdef CONFIG_LCD
2.1.3
Does it fix the problem if you just remove it from the device tree?
That should indeed work as well, but i haven't tested it thusfar.
Would you simply like to see that tested, or are you suggesting to keep CONFIG_VIDEO_PARADE around ?
Some background - I'd like to have an exynos5-dt board config which is used by the various Chromebooks (and perhaps other boards to) where the only difference is the device tree. At present the peach-pi.h file is mostly identical to peach-pit.h, so then we can avoid #ifdefs in the code, etc.
For memory size we can specify it with device tree, although the patch for this has yet to land.
So in general I'm keen for this peach-pi.h file to go away and be replaced with a CONFIG_DEFAULT_DEVICE_TREE line in the defconfig. If all you need to change is the device tree then that is best.
Regards, Simon