Hi,
On Mon, Nov 14, 2016 at 12:18:06PM +0100, Hans de Goede wrote:
#ifdef CONFIG_SPL_SPI_SUNXI @@ -143,7 +157,14 @@ #define CONFIG_GENERIC_MMC #define CONFIG_MMC_SUNXI #define CONFIG_MMC_SUNXI_SLOT 0 -#define CONFIG_ENV_IS_IN_MMC +#endif
+#if defined(CONFIG_ENV_IS_IN_NAND) +#define CONFIG_ENV_OFFSET 0xc00000 +#define CONFIG_ENV_SIZE 0x400000 +#elif defined(CONFIG_ENV_IS_IN_MMC) +#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 + 512) KiB */ +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ #define CONFIG_SYS_MMC_ENV_DEV 0 /* first detected MMC controller */ #endif
I would greatly prefer putting the env in an UBI partition, I thought that we had agreed on doing that ?
That was mentionned a few times, but I didn't remember having a final decision. I'm not really sure that putting the environment in UBI would be a good idea.
Attaching the UBI volume takes a very significant time. Doing so before the user can see that something is happening in the system feels pretty bad.
Maxime