Wolfgang,
As Timur pointed out, the post framework doesn't work for us. After U-boot relocate itself to RAM, we have only 2GB memory to test. The best place is before relocation. Many other boards do that. Following your idea of reusing code, I can only reuse the test pattern generator. I am open to suggestions.
York Sun ----- Original Message ----- From:"Wolfgang Denk" wd@denx.de To:"York Sun" yorksun@freescale.com Cc:"Timur Tabi" timur.tabi@gmail.com, "Kumar Gala" galak@kernel.crashing.org, "u-boot@lists.denx.de" u-boot@lists.denx.de Sent:7/28/2010 4:50 PM Subject:Re: [U-Boot] [PATCH 8/8] powerpc/85xx: Add memory test feature for mpc85xx.
Dear York Sun,
In message 1280351179.8571.63.camel@oslab-l1 you wrote:
We already have too many different implementations of a memory test in U-Boot, and I will not accept adding yet another one.
I can reuse your testing code but have to move the desired code out of memory.c file to avoid the need for CONFIG_POST and CONFIG_SYS_POST_MEMORY. I also add a progress indicator. My testing
NAK, and NAK.
Please integrate your code into the existing POST framework instead, as a number of other boards already did.
A progress indicator may be a nice little toy, but how does it integrate into the POST framework?
target is 2GB at a time, up to physically memory size which is easily over 8GB. Without progress indicator, it feels hung when it is actually running.
Yes, memory testing takes time. In the context of a power-on self test (and this is what you are doing, right?) we should take care to fit it into the existing framework, though.
Please take a look at the patch below.
Instead of integrating your needs into an existing framework you invent yet another one. I don't want to have this, sorry.
Best regards,
Wolfgang Denk