On Wed, Apr 13, 2011 at 12:45 PM, Wolfgang Denk wd@denx.de wrote:
Dear Simon Glass,
In message BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com you wrote:
+static void smsc95xx_halt(struct eth_device *eth) +{
- debug("** %s()\n", __func__);
+}
is this right ? shouldnt you be halting something ?
I could do, but halting is not in the driver at present. Do you think it is important?
Yes, it is important to shut down devices. Especially with USB devices.
OK I will put something together. I am finding the rebase juggling a little tricky so there will be a delay while I sort that out so I can test properly.
BTW: can you *please* fix your mail addresses? It's not "Remy Bohmerl inux@bohmer.net" but "Remy Bohmer linux@bohmer.net" instead. Don't you get tons of bounce messages?
Have fixed it. No bounces yet, maybe you have a brother? :-)
Regards, Simon
Best regards,
Wolfgang Denk