On Fri, May 22, 2009 at 03:24:31PM -0500, Peter Tyser wrote:
Signed-off-by: Peter Tyser ptyser@xes-inc.com
I don't have any 83xx boards to try this on, but I verified the dma code still works on an 86xx board. An easy way to test this change (Ira?) would be to enable CONFIG_FSL_DMA and CONFIG_SYS_DMA_MEMTEST after the "85xx/86xx dma updates" and "Add optional dma transfers to mtest" patch series have been applied.
This patch dirties up the fsl_dma code a bit and no one is currently using the 83xx dma code, so its value is debatable. Maybe others will find it useful or want to include it to support the 83xx down the road.
Hello Peter,
I've given this patch (along with the two required patch series) a whirl on my MPC8349EMDS board. As best I can tell, it works exactly as expected. I've also reviewed the changes for the 83xx controller, and they look great. You've done a great job of minimizing the code differences between the 83xx and 86xx controllers.
It would definitely make some of my future work easier if this gets accepted. Feel free to add my reviewed-by and tested-by to your patch.
Reviewed-by: Ira W. Snyder iws@ovro.caltech.edu Tested-by: Ira W. Snyder iws@ovro.caltech.edu
Thanks, Ira